Properly implements old call-path of status codes#934
Merged
codefromthecrypt merged 2 commits intomasterfrom Jul 3, 2019
Merged
Properly implements old call-path of status codes#934codefromthecrypt merged 2 commits intomasterfrom
codefromthecrypt merged 2 commits intomasterfrom
Conversation
Eventhough new instrumentation don't use it, old could. See spring-cloud/spring-cloud-sleuth#1387
Member
Author
|
WIP as needs tests |
marcingrzejszczak
approved these changes
Jul 3, 2019
Member
Author
|
I looked at all the javadoc to see what could return what, then double-checked source code and got a little defensive about method chaining too |
codefromthecrypt
changed the title
Member
Author
|
backfilled all the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eventhough new instrumentation don't use it, old could.
See spring-cloud/spring-cloud-sleuth#1387